Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate the expiration list into multiple buckets #160

Open
shafreeck opened this issue Dec 26, 2019 · 0 comments
Open

Separate the expiration list into multiple buckets #160

shafreeck opened this issue Dec 26, 2019 · 0 comments
Labels
enhancement New feature or request
Projects
Release 1.0
Milestone
Release 1.0

Comments

@shafreeck
Copy link
Contributor

shafreeck commented Dec 26, 2019 •
edited

The implementation of the expiration list now is a big list of keys that shares a common prefix. There are two problems with this design.

  1. If all the keys set with at some TTL, the expiration time acts like an incrementing ID which may cause write hotspot on a single region.
  2. The expiration items are deleted sequentially, which causes a continuous range of tombstone keys. It has a big impact on the performance of RocksDB
@shafreeck shafreeck added the enhancement New feature or request label Dec 26, 2019
@shafreeck shafreeck added this to To do in Release 1.0 via automation Dec 26, 2019
@shafreeck shafreeck modified the milestone: Release 1.0 Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Release 1.0
  
To do
Milestone
Release 1.0
Development

No branches or pull requests
1 participant
@shafreeck