-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Private Registry Configuration Question related to redis #2573
Comments
Hello All, Can some one please review this issue and share your views |
I'm not super familiar with sentinel or overall Redis HA. We do not do anything specific in the registry about them though, and rely on this client library: https://github.com/garyburd/redigo/ There is limited interest at this point into redis caching - so I would suggest you do a couple of tests with cluster and sentinel, and share the results here with the community. |
Looking at redigo, I can see:
from where I'm infering that "if redigo had that support, there wouldn't be those "extensions" to the library. In fact, even "FZambia/sentinel" suggests: «Alternative solution - You can alternatively configure Haproxy» (which is basically what everyone seems to be doing for backwards compatibility with non-sentinel clients. So my understanding is that docker registry does not support a sentinel-managed Redis setup (nor a Redis Cluster setup). |
No, the current implementation does not support Redis [sentinel] cluster. We're open to accepting PRs if you fancy adding support for them. Given this question has been answered I'll close it now. |
Does Docker Private Registry support Redis cluster or Redis sentinel? Reference: https://docs.docker.com/registry/configuration/#overriding-the-entire-configuration-file.
After reviewing this link, I understand that redis can be used as a blobdescriptor. Further by defining the redis server & port details under redis: section, one can configure registry to use redis for layer metadata caching. But what is not clearly mentioned is the support for redis advanced features like sentinel or cluster. As per redis documentation, client libraries should be able to understand the redirection and connect to the redis server in case of failovers (from sentinel when master fails and a slave is promoted as new master) or when data hash is found in a different redis node ( than the currently connected node in the redis pool). Is registry is coded to understand these redirections and work? I am looking forward to understand how registry behaves in these mentioned scenarios to architect a high available setup for Docker Private Registry. Thanks in advance for any help or suggestions.
The text was updated successfully, but these errors were encountered: