New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should output.TotalWritten be judged after cmd.Wait() is executed? #1319

Closed

cobolbaby opened this issue Apr 18, 2023 · 1 comment · Fixed by #1389

Labels

bug

Contributor

cobolbaby commented Apr 18, 2023

dkron/builtin/bins/dkron-executor-shell/shell.go

Lines 130 to 135 in 9982ceb

    
           // Warn if buffer is overwritten 
        
           if output.TotalWritten() > output.Size() { 
        
           	log.Printf("shell: Script '%s' generated %d bytes of output, truncated to %d", command, output.TotalWritten(), output.Size()) 
        
           } 
        
           err = cmd.Wait()

Should output.TotalWritten be judged after cmd.Wait() is executed?

Member

vcastellm commented Jul 23, 2023

Yes, it makes sense.

vcastellm added the bug label

cobolbaby mentioned this issue

feat(dkron-executor-shell): some improvement #1389

Merged

vcastellm closed this as completed in #1389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment