Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Executors / NATS documentation #928

Closed
tomercagan opened this issue Mar 19, 2021 · 1 comment · Fixed by #929
Closed

Typo in Executors / NATS documentation #928

tomercagan opened this issue Mar 19, 2021 · 1 comment · Fixed by #929

Comments

@tomercagan
Copy link

tomercagan commented Mar 19, 2021

Describe the bug
Typo in executors documentation - Shell executor is listed twice instead of shell and NATS

To Reproduce
Steps to reproduce the behavior:

  1. Go to the website
  2. Navigate to Usage > Executors
  3. Observe there are two links to "Shell Executors"
  4. Click first "Shell Executor" to navigate into the NATS executor
  5. Observe typo in title "Shell Executor"

Expected behavior
Index page should show link to "NATS Executor"
NATS Executor page should have a title "NATS Executor"

Screenshots
Index page showing wrong link title
dkron_executors_index

NATS page showing wrong title
dkron_executors_nats

Specifications:
N/A

Additional context
I thought this would be faster than forking and making a PR :-)

@yvanoers
Copy link
Collaborator

@tomercagan Thanks for your watchfulness!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants