Performance data for Volumes that are in Critical state is not included in output

[mdollemore]

Bug report

When a volume is reporting as Critical, then performance data for that volume is not output by the check.

• check_netapp_ontap version: v3.03.200924
• NetApp Ontap version: 9
• Monitoring solution: OMD 3.31~2020-09-13-labs-edition

Expected Behavior
Performance data should be output for all Volumes regardless of threshold state.

Actual Behavior
Performance data is output for all volumes that are not in a Critical state.

How to reproduce Behavior
Set a threshold which will result in some volumes going into a critical state and check the performance data output, volumes that are in a critical state will not be included in the performance data output.

Issue is caused by the sub space_threshold_helper which is called twice, first with $alertlevel =2 and then with $alertlevel =1. Volumes are removed from the list of volumes during the first call if they exceed the critical threshold, however $perfoutput is only produced if ($intAlertLevel == 1). Hence, Volumes that had critical threshold are not processed in the second call to the sub and therefor do not get any perdata output.