Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimator Score Visualizers #44

Closed
bbengfort opened this issue Sep 7, 2016 · 6 comments
Closed

Estimator Score Visualizers #44

bbengfort opened this issue Sep 7, 2016 · 6 comments
Assignees
Labels
level: intermediate python coding expertise required priority: high should be done before next release type: feature a new visualizer or utility for yb
Milestone

Comments

@bbengfort
Copy link
Member

bbengfort commented Sep 7, 2016

No description provided.

@bbengfort bbengfort added this to the Version 0.3 milestone Sep 7, 2016
@bbengfort bbengfort self-assigned this Sep 7, 2016
@bbengfort bbengfort added the ready label Sep 7, 2016
@rebeccabilbro rebeccabilbro added level: intermediate python coding expertise required priority: high should be done before next release type: feature a new visualizer or utility for yb labels Sep 7, 2016
@rebeccabilbro
Copy link
Member

Implement a base class that will follow an estimator in a pipeline (keep in mind that there could be more than one of these things stacked up along each other). This is not a transformer. It needs to extend BaseEstimator, VisualizerMixin. We also need to create a ScoringMixin. ScoringMixin has scoring function that saves the state of the scoring to the class so that we can draw it. This will have:

  • fit
  • predict
  • score
  • draw

Need to think how we'll access the model from ScoreVisualizer. Best option is to have it be instantiated with a model form - this makes sense because we would call fit down into the estimator. The trick will be that the visual pipeline needs to know not to run fit twice.

@bbengfort bbengfort added in progress label for Waffle board and removed ready labels Sep 26, 2016
@rebeccabilbro
Copy link
Member

@rebeccabilbro
Copy link
Member

ClassifierScoreVisualizers:

RegressionScoreVisualizers:

@bbengfort
Copy link
Member Author

bbengfort commented Oct 8, 2016

@rebeccabilbro ok I took a look at these, and things are looking great! There are a few things that we should resolve/discuss and this issue will be done!

Also - I really like how you've separated score and draw and poof - it was the basis for everything I did in the feature visualizers!

@rebeccabilbro
Copy link
Member

@bbengfort have addressed the first two checkboxes in commits d57102c and 76d2d1f

Will tackle the third in the next sprint.

As for the 4th, I've clarified the difference in base.py here. Essentially the main difference is that ScoreVisualizer takes a fitted model and ModelVisualizer takes a model form.

@rebeccabilbro
Copy link
Member

Marking as complete, with the understanding that issue #62 will resolve the fig/ax hook question that came up in the design of this class.

@rebeccabilbro rebeccabilbro removed the in progress label for Waffle board label Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level: intermediate python coding expertise required priority: high should be done before next release type: feature a new visualizer or utility for yb
Projects
None yet
Development

No branches or pull requests

2 participants