Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutating prop issue #214

Closed
henrikruscon opened this issue Aug 17, 2021 · 2 comments
Closed

Mutating prop issue #214

henrikruscon opened this issue Aug 17, 2021 · 2 comments

Comments

@henrikruscon
Copy link
Contributor

This line of code mutates prop

this.question.answered = this.isValid()

@spinn
Copy link
Contributor

spinn commented Aug 24, 2021

Hi @henrikdahl,

thanks for the report. Can you provide a test case when this error happens? Or are you referring to the fact we are changing a property of QuestionModel (or a "prop" of the question component if you're defining questions with components; although take note we're actually using a copy of the prop value in this case)? This is inevitable and necessary with how Vue Flow Form is currently designed - it also changes many other properties of QuestionModel, but this is unavoidable (and completely expected) when using class instances.

@phre1
Copy link
Contributor

phre1 commented Sep 28, 2021

Closing - Inactive issue

@phre1 phre1 closed this as completed Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants