Skip to content

Commit

Permalink
chore!: move faculty feedback params to POST body
Browse files Browse the repository at this point in the history
For the sake of proper HTTP semantics, we do it.

BREAKING: will break old API clients/usages. Must only be merged
when auto-update pipeline for client libraries is in place.
  • Loading branch information
ditsuke committed Apr 14, 2023
1 parent d7aec6b commit 8e6c8ef
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion server/proto/v1/amizone.proto
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,10 @@ service AmizoneService {
option (google.api.http) = {delete: "/api/v1/wifi_mac/{address}"};
}
rpc FillFacultyFeedback(FillFacultyFeedbackRequest) returns (FillFacultyFeedbackResponse) {
option (google.api.http) = {post: "/api/v1/faculty/feedback/submit"};
option (google.api.http) = {
post: "/api/v1/faculty/feedback/submit",
body: "*"
};
}
}

Expand Down

0 comments on commit 8e6c8ef

Please sign in to comment.