Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix required ditto version checking #134

Merged
merged 1 commit into from Jan 6, 2023

Conversation

jmackie
Copy link
Member

@jmackie jmackie commented Jan 5, 2023

I tried adding a required ditto version to https://github.com/ditto-lang/std

diff --git a/ditto.toml b/ditto.toml
index 835b5b2..691be46 100644
--- a/ditto.toml
+++ b/ditto.toml
@@ -1,5 +1,6 @@
 name = "std"
 targets = ["web", "nodejs"]
+ditto-version = ">=0.0.2"

But that complained with:

  × error generating build.ninja
  ╰─▶ ditto version requirement not met for current_package: current version = 0.0.2-1-g2ea38ab, wanted = >=0.0.2

Maybe there's a way to specify in the requirement that pre should be ignored, but I also think ditto-version = ">=0.0.2" should just work. This PR makes it so.

(I also took the underscore out of current_package while I was there)

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #134 (306f878) into main (2ea38ab) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   84.09%   84.10%           
=======================================
  Files          83       83           
  Lines       15377    15382    +5     
=======================================
+ Hits        12932    12937    +5     
  Misses       2445     2445           
Impacted Files Coverage Δ
crates/ditto-make/src/build_ninja.rs 95.01% <100.00%> (+0.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jmackie jmackie merged commit a1d9631 into main Jan 6, 2023
@jmackie jmackie deleted the fix-required-ditto-version-checking branch January 6, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant