New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Very strange result #12
Comments
Hi @simmed00, Could you try more pockets and evaluate the results? It's worth noting that GraphBP is an early attempt for this challenging structure-based drug design problem, and there is a large space for performance improvement. Thus, the generated molecules for some pockets may not be good. Thank you. |
Thank you very much for the prompt reply. I was thinking could this because of the line: Chem.SanitizeMol(rd_mol,Chem.SANITIZE_ALL^Chem.SANITIZE_KEKULIZE) |
Hi, could you point me to the specific line you are referring to? I have not tested the code on Windows yet. That could be the reason of using RDKit on Windows. But I am not sure. |
The code is around bond_adding.py line 324 try: Thanks in advance. |
I haven't meet this before on Linux. Will take a deeper look. |
I tried it on Linux, the exception is now gone without modifying your code. So the previous error is possibly due to RDKit compatibility on windows. |
Sounds great. That's a good catch! |
Thanks for the great work and sharing the code.
I run it according to the instruction using the provided train_epoch33 model.
I test it on one pocket, I picked a line from the train file and put into the test_selected_targets.type as below:
1 0 1.90832 1A1C_MALDO_2_433_0/1m7y_A_rec.pdb 1A1C_MALDO_2_433_0/1m7y_ppg_uff2.sdf.gz #-4.20313
I run main_gen then main_eval.py. But main_eval will raise exception for every generated molecule by the line in bond_adder:
Chem.SanitizeMol(rd_mol,Chem.SANITIZE_ALL^Chem.SANITIZE_KEKULIZE)
So I modify it to
Chem.SanitizeMol(rd_mol)
Then everything is smooth.
However, the results look really strange. I can post some here for your reference.
Is there something I do it wrong in the step described above? Looking forward to your reply.
The text was updated successfully, but these errors were encountered: