Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): enable scss design tokens local usage #37

Merged
merged 7 commits into from Nov 11, 2022

Conversation

sebastiandg7
Copy link
Member

Current Behavior

We are not able to use the style-dictionary built SCSS design tokens into the Stencil component library.

Expected Behavior

Being able to use the SCSS design tokens to style our Stencil components just just building the coral-tokens package locally.

Related Issue(s)

Fixes #

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@nx-cloud
Copy link

nx-cloud bot commented Nov 11, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8bf6983. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@stackblitz
Copy link

stackblitz bot commented Nov 11, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@AndresVD21 AndresVD21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastiandg7 sebastiandg7 merged commit 346d935 into main Nov 11, 2022
@sebastiandg7 sebastiandg7 deleted the feat/core/enable-tokens-locally branch November 11, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants