Skip to content
This repository has been archived by the owner on Oct 29, 2019. It is now read-only.

Better model/attribute names #67

Closed
mikek opened this issue Feb 2, 2015 · 2 comments
Closed

Better model/attribute names #67

mikek opened this issue Feb 2, 2015 · 2 comments
Assignees

Comments

@mikek
Copy link
Contributor

mikek commented Feb 2, 2015

I am sorry to bring this up again, but if the app is going to be an example, this is something to consider.
Since namespace is not the only thing that NewsBlogConfig model can store... what is the better name for a namespace FK? app_config or app_hook_config or just config? @yakky what is your preference? Doing it early will be less painful.

I've also tried renaming Article to Entry (as a more general name for bog post and news article). Both Django and South migrations are straightforward, renaming templates and all context variables was also possible. The thing that have eventually stopped me was a huge number of article mentions in the test suite =) This would also affect any project already using the app a lot. Article is not a that bad name after all, so renaming a model seems not to be worth it.

@yakky
Copy link
Contributor

yakky commented Feb 3, 2015

probably app_config is the most sensible as it's kind of self explanatory

@mikek
Copy link
Contributor Author

mikek commented Feb 3, 2015

Implemented in #68

@mikek mikek closed this as completed Feb 3, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants