Revert "Let link attributes be optional" (#251)

django-cms · Jul 5, 2016 · 2e5eb36 · 2e5eb36
1 parent 9255f8f
commit 2e5eb36
Show file tree

Hide file tree

Showing 7 changed files with 3 additions and 85 deletions.
diff --git a/HISTORY b/HISTORY
@@ -7,7 +7,6 @@ CHANGELOG
 * Pinned to djangocms-attributes-field v0.1.0
 * Fixed model name used in migration
 * Fixed an issue with folder plugin in Django 1.9
-* Allowed link attributes to be optional
 
 
 1.1.1 (2016-06-22)

diff --git a/cmsplugin_filer_file/migrations/0004_auto_20160705_1136.py b/cmsplugin_filer_file/migrations/0004_auto_20160705_1136.py
diff --git a/cmsplugin_filer_file/models.py b/cmsplugin_filer_file/models.py
@@ -40,7 +40,7 @@ class FilerFile(CMSPlugin):
     target_blank = models.BooleanField(_('Open link in new window'), default=False)
     style = models.CharField(
         _('Style'), choices=STYLE_CHOICES, default=DEFAULT_STYLE, max_length=255, blank=True)
-    link_attributes = AttributesField(excluded_keys=EXCLUDED_KEYS, blank=True,
+    link_attributes = AttributesField(excluded_keys=EXCLUDED_KEYS,
                                       help_text=_('Optional. Adds HTML attributes to the rendered link.'))
 
     objects = FilerPluginManager(select_related=('file',))

diff --git a/cmsplugin_filer_image/migrations/0008_auto_20160705_1136.py b/cmsplugin_filer_image/migrations/0008_auto_20160705_1136.py
diff --git a/cmsplugin_filer_image/models.py b/cmsplugin_filer_image/models.py
@@ -74,7 +74,7 @@ class FilerImage(CMSPlugin):
                                         help_text=_("if present image will be clickable"))
     description = models.TextField(_("description"), blank=True, null=True)
     target_blank = models.BooleanField(_('Open link in new window'), default=False)
-    link_attributes = AttributesField(excluded_keys=EXCLUDED_KEYS, blank=True,
+    link_attributes = AttributesField(excluded_keys=EXCLUDED_KEYS,
                                       help_text=_('Optional. Adds HTML attributes to the rendered link.'))
 
     # we only add the image to select_related. page_link and file_link are FKs

diff --git a/cmsplugin_filer_link/migrations/0006_auto_20160705_1136.py b/cmsplugin_filer_link/migrations/0006_auto_20160705_1136.py
diff --git a/cmsplugin_filer_link/models.py b/cmsplugin_filer_link/models.py
@@ -41,7 +41,7 @@ class FilerLinkPlugin(CMSPlugin):
     new_window = models.BooleanField(_("new window?"), default=False,
                 help_text=_("Do you want this link to open a new window?"))
     file = FilerFileField(blank=True, null=True, on_delete=models.SET_NULL)
-    link_attributes = AttributesField(excluded_keys=EXCLUDED_KEYS, blank=True,
+    link_attributes = AttributesField(excluded_keys=EXCLUDED_KEYS,
                                       help_text=_('Optional. Adds HTML attributes to the rendered link.'))
 
     def __str__(self):