URLs that stay the same when a file is replaced. Fixes #478 #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if self.file and self.is_public: | ||
| try: | ||
| url = urlresolvers.reverse('canonical', kwargs={ | ||
| 'uploaded_at': self.uploaded_at.strftime('%s'), |
There was a problem hiding this comment.
We can use the File.uploaded_at field, which is non-editable, to make the public file's canonical URL a little bit harder to guess.
jvamvas
changed the title
|
@jvamvas really nice |
| from filer import views | ||
|
|
||
| urlpatterns = [ | ||
| url(r'canonical/(?P<uploaded_at>[0-9]+)/(?P<file_id>[0-9]+)/$', views.canonical, name='canonical'), |
There was a problem hiding this comment.
How about making the canonical part of the path configurable?
|
@stefanfoulis @mkoistinen is this good for you? |
|
@yakky 👍 from me :-) |
|
@jvamvas merged. Thanks a lot for your great work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes users share the direct URL of public files. But whenever they update the file in the "advanced" panel on the file's admin page, the direct URL changes as well.
Perhaps django-filer could include a canonical URL that redirects to the latest version of a public file and that can be shared safely:
If they wish to use canonical URLs, users need to include filer's URLConf in their project's
urls.py. If they don't configure their project that way, or if they create a non-public file, the filer admin does not display a canonical URL.