Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon code alignments #27

Merged
merged 9 commits into from Jan 21, 2019
Merged

Addon code alignments #27

merged 9 commits into from Jan 21, 2019

Conversation

FinalAngel
Copy link
Member

@FinalAngel FinalAngel commented Jan 16, 2019

  • Added isort and adapted imports
  • Adapted code base to align with other supported addons

General

  • Update changelog
    Adapted code base to align with other supported addons
  • Add contributors text to README file
    We're grateful to all contributors who have helped create and maintain this package. Contributors are listed at [link to https://github.com/divio/djangocms-video/graphs/contributors].
  • Check that python, django, django-cms and other versions are listed correctly (add badge)
  • Make sure Django is not pinned in setup.py
  • Align gitignore files
  • Align setup.py
  • Keep the two line rule

Tests

  • Make sure naming for the test files is test_.py
  • Add tests_migration.py file if missing
  • Remove test migration check in other files
  • Check requirements.txt file for accuracy (e.g. unpin djangocms-helper)
  • Check settings.py that it is ordered correctly
  • Added isort and updated files

Internal

  • Run internal checklist

@codecov-io
Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #27 into master will decrease coverage by 0.14%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage      33%   32.86%   -0.15%     
==========================================
  Files          16       16              
  Lines         718      712       -6     
  Branches       71       71              
==========================================
- Hits          237      234       -3     
+ Misses        481      478       -3
Impacted Files Coverage Δ
djangocms_history/cms_plugins.py 100% <ø> (ø) ⬆️
djangocms_history/views.py 42.1% <ø> (ø) ⬆️
djangocms_history/forms.py 100% <ø> (ø) ⬆️
djangocms_history/action_handlers.py 22.36% <ø> (ø) ⬆️
djangocms_history/operation_handlers.py 19.83% <ø> (ø) ⬆️
djangocms_history/actions.py 100% <ø> (ø) ⬆️
djangocms_history/datastructures.py 50% <ø> (ø) ⬆️
djangocms_history/compat.py 100% <ø> (ø) ⬆️
djangocms_history/signals.py 100% <ø> (ø) ⬆️
djangocms_history/helpers.py 30.76% <ø> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ce6366...45b923b. Read the comment docs.

@FinalAngel FinalAngel merged commit 9f572e0 into master Jan 21, 2019
@FinalAngel FinalAngel deleted the feature/cleanup branch January 21, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants