Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a bug when child plugin cannot be edited while text plugin isn't created #371

Merged
merged 3 commits into from
Sep 14, 2016
Merged

Fixed a bug when child plugin cannot be edited while text plugin isn't created #371

merged 3 commits into from
Sep 14, 2016

Conversation

vxsx
Copy link
Contributor

@vxsx vxsx commented Sep 14, 2016 •
edited
Loading

text plugin assumed that current url is always /cms/page/edit-plugin/{id} but in fact it can be /cms/page/add-plugin

@lory87
Copy link

lory87 commented Sep 14, 2016

👍

@coveralls
Copy link

coveralls commented Sep 14, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 82.26% when pulling 5011913 on vxsx:bugfix/edit-child-plugin-while-adding-text-plugin into f8fcaf8 on divio:master.

@coveralls
Copy link

coveralls commented Sep 14, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 82.26% when pulling 5011913 on vxsx:bugfix/edit-child-plugin-while-adding-text-plugin into f8fcaf8 on divio:master.

@FinalAngel
Copy link
Member

LGTM

@vxsx vxsx merged commit 9feef55 into django-cms:master Sep 14, 2016
@vxsx vxsx deleted the bugfix/edit-child-plugin-while-adding-text-plugin branch September 14, 2016 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vxsx @lory87 @coveralls @FinalAngel