New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible perfomance issue #9

Closed

alexey-sh opened this issue Sep 21, 2022 · 1 comment

alexey-sh commented Sep 21, 2022

divkit/json-builder/typescript/src/helper.ts

Line 23 in 310b5fe

const [node, path] = stack.shift() as [unknown, string[]];

Implementation of Array.shift can be slow

https://bugs.chromium.org/p/v8/issues/detail?id=12730

Collaborator

4eb0da commented Jan 24, 2023

Thanks for your report! This function was optimized in the commit 62f6a8e
Sorry for the delay

lunarstill closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment