Other: improve catching errors

core/commands/status_bar.py

@@ -53,14 +53,15 @@ def run(self, edit):
             last_execution = int(round(time.time() * 1000))
 
     def run_async(self):
-        # Short-circuit update attempts for files not part of Git repo.
-        if not self._repo_path(throw_on_stderr=False):
-            self.view.erase_status("gitsavvy-repo-status")
-            return
-
+        # disable logging and git raise error
         with debug.disable_logging():
-            short_status = self.get_branch_status_short()
-        self.view.set_status("gitsavvy-repo-status", short_status)
+            # ignore all other possible errors
+            try:
+                self.repo_path  # check for ValueError
+                short_status = self.get_branch_status_short()
+                self.view.set_status("gitsavvy-repo-status", short_status)
+            except Exception as e:
+                self.view.erase_status("gitsavvy-repo-status")
 
         global update_status_bar_soon
         update_status_bar_soon = False

core/git_command.py

@@ -9,6 +9,7 @@
 import os
 import subprocess
 import shutil
+from contextlib import contextmanager
 
 import sublime
 
@@ -97,19 +98,15 @@ def git(self, *args,
 
         stdout, stderr = None, None
 
-        def raise_error(msg):
-            if type(msg) == str and "fatal: Not a git repository" in msg:
+        try:
+            if not working_dir:
+                working_dir = self.repo_path
+        except Exception as e:
+            # offer initialization when "Not a git repository" is thrown from self.repo_path
+            if type(e) == ValueError and e.args and "Not a git repository" in e.args[0]:
                 sublime.set_timeout_async(
                     lambda: sublime.active_window().run_command("gs_offer_init"))
-
-            elif type(msg) == str and "*** Please tell me who you are." in msg:
-                sublime.set_timeout_async(
-                    lambda: sublime.active_window().run_command("gs_setup_user"))
-
-            sublime.status_message(
-                "Failed to run `git {}`. See log for details.".format(command[1])
-            )
-            raise GitSavvyError(msg)
+            raise GitSavvyError(e)
 
         try:
             startupinfo = None
@@ -124,15 +121,16 @@ def raise_error(msg):
                                  stdin=subprocess.PIPE,
                                  stdout=subprocess.PIPE,
                                  stderr=subprocess.PIPE,
-                                 cwd=working_dir or self.repo_path,
+                                 cwd=working_dir,
                                  env=environ,
                                  startupinfo=startupinfo)
             stdout, stderr = p.communicate((stdin.encode(encoding=stdin_encoding) if encode else stdin) if stdin else None)
             if decode:
                 stdout, stderr = self.decode_stdout(stdout, savvy_settings), stderr.decode()
 
         except Exception as e:
-            raise_error(e)
+            # this should never be reached
+            raise GitSavvyError("Please report this error to GitSavvy:\n\n{}".format(e))
 
         finally:
             end = time.time()
@@ -147,8 +145,16 @@ def raise_error(msg):
                     end - start
                 )
 
-        if not p.returncode == 0 and throw_on_stderr:
-            raise_error("`{}` failed with following output:\n{}\n{}".format(
+        if throw_on_stderr and not p.returncode == 0:
+            sublime.status_message(
+                "Failed to run `git {}`. See log for details.".format(command[1])
+            )
+
+            if "*** Please tell me who you are." in stderr:
+                sublime.set_timeout_async(
+                    lambda: sublime.active_window().run_command("gs_setup_user"))
+
+            raise GitSavvyError("`{}` failed with following output:\n{}\n{}".format(
                 command_str, stdout, stderr
             ))
 
@@ -227,7 +233,7 @@ def find_working_dir(self):
 
         return None
 
-    def find_repo_path(self, throw_on_stderr=False):
+    def find_repo_path(self):
         """
         Similar to find_working_dir, except that it does not stop on the first
         directory found, rather on the first git repository found.
@@ -248,7 +254,7 @@ def find_repo_path(self, throw_on_stderr=False):
                 folders = window.folders()
                 if folders and os.path.isdir(folders[0]):
                     repo_path = self.find_git_toplevel(
-                        folders[0], throw_on_stderr=throw_on_stderr)
+                        folders[0], throw_on_stderr=False)
 
         return os.path.realpath(repo_path) if repo_path else None
 
@@ -264,38 +270,24 @@ def find_git_toplevel(self, folder, throw_on_stderr):
 
     @property
     def repo_path(self):
-        return self._repo_path()
-
-    @property
-    def short_repo_path(self):
-        if "HOME" in os.environ:
-            return self.repo_path.replace(os.environ["HOME"], "~")
-        else:
-            return self.repo_path
-
-    def _repo_path(self, throw_on_stderr=True):
         """
         Return the absolute path to the git repo that contains the file that this
         view interacts with.  Like `file_path`, this can be overridden by setting
         the view's `git_savvy.repo_path` setting.
-
-        Do not raise error when throw_on_stderr is `False`. It is needed
-        in GsUpdateStatusBarCommand, otherwise, spurious popup will be shown.
         """
         # The below condition will be true if run from a WindowCommand and false
         # from a TextCommand.
         view = self.window.active_view() if hasattr(self, "window") else self.view
         repo_path = view.settings().get("git_savvy.repo_path") if view else None
 
         if not repo_path or not os.path.exists(repo_path):
-            repo_path = self.find_repo_path(throw_on_stderr=throw_on_stderr)
+            repo_path = self.find_repo_path()
             if not repo_path:
-                # don't throw error for detached view
-                view_is_detached = view and not view.window()
-                if not view_is_detached and throw_on_stderr:
-                    raise ValueError("Unable to determine Git repo path.")
+                window = view.window()
+                if window and window.folders():
+                    raise ValueError("Not a git repository.")
                 else:
-                    return None
+                    raise ValueError("Unable to determine Git repo path.")
 
             if view:
                 file_name = view.file_name()
@@ -305,6 +297,13 @@ def _repo_path(self, throw_on_stderr=True):
 
         return os.path.realpath(repo_path) if repo_path else repo_path
 
+    @property
+    def short_repo_path(self):
+        if "HOME" in os.environ:
+            return self.repo_path.replace(os.environ["HOME"], "~")
+        else:
+            return self.repo_path
+
     @property
     def file_path(self):
         """