Fix: use urllib.urlencode for branch names containing hash tag

timbrel · Mar 5, 2018 · 4413118 · 4413118
1 parent 4ba9966
commit 4413118
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/github/commands/pull_request.py b/github/commands/pull_request.py
@@ -1,6 +1,7 @@
 import sublime
 from sublime_plugin import WindowCommand
 from webbrowser import open as open_in_browser
+import urllib
 
 from ...core.git_command import GitCommand
 from ...core.ui_mixins.quick_panel import show_paginated_panel
@@ -187,13 +188,13 @@ def open_comparision_in_browser(self, owner, branch):
         base_owner = base_remote.owner
         base_branch = self.get_integrated_branch_name()
 
-        open_in_browser("{}/compare/{}:{}...{}:{}?expand=1".format(
+        open_in_browser(urllib.urlencode("{}/compare/{}:{}...{}:{}?expand=1".format(
             url,
             base_owner,
             base_branch,
             owner,
             branch
-        ))
+        )))
 
 
 class GsGithubPushAndCreatePullRequestCommand(GsPushToBranchNameCommand):

diff --git a/github/github.py b/github/github.py
@@ -6,6 +6,7 @@
 from collections import namedtuple
 from webbrowser import open as open_in_browser
 from functools import partial
+import urllib
 
 import sublime
 
@@ -95,7 +96,7 @@ def open_file_in_browser(rel_path, remote, commit_hash, start_line=None, end_lin
         lines=line_numbers
     )
 
-    open_in_browser(url)
+    open_in_browser(urllib.urlencode(url))
 
 
 def open_repo(remote):

diff --git a/gitlab/commands/merge_request.py b/gitlab/commands/merge_request.py
@@ -1,6 +1,7 @@
 import sublime
 from sublime_plugin import WindowCommand
 from webbrowser import open as open_in_browser
+# import urllib
 
 from ...core.git_command import GitCommand
 from ...core.ui_mixins.quick_panel import show_paginated_panel
@@ -173,13 +174,13 @@ def open_mr_in_browser(self):
 #         base_owner = base_remote.owner
 #         base_branch = self.get_integrated_branch_name()
 
-#         open_in_browser("{}/compare/{}:{}...{}:{}?expand=1".format(
+#         open_in_browser(urllib.urlencode("{}/compare/{}:{}...{}:{}?expand=1".format(
 #             url,
 #             base_owner,
 #             base_branch,
 #             owner,
 #             branch
-#         ))
+#         )))
 
 
 # class GsPushAndCreateMergeRequestCommand(GsPushToBranchNameCommand):

diff --git a/gitlab/gitlab.py b/gitlab/gitlab.py
@@ -6,6 +6,7 @@
 from collections import namedtuple
 from functools import partial, lru_cache
 from webbrowser import open as open_in_browser
+import urllib
 
 import sublime
 
@@ -97,7 +98,7 @@ def open_file_in_browser(rel_path, remote, commit_hash, start_line=None, end_lin
         lines=line_numbers
     )
 
-    open_in_browser(url)
+    open_in_browser(urllib.urlencode(url))
 
 
 def open_repo(remote):