Fix: urlencode is in urllib.parse

timbrel · Mar 7, 2018 · 9cbcdc4 · 9cbcdc4
1 parent 7ddd7cb
commit 9cbcdc4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/github/commands/pull_request.py b/github/commands/pull_request.py
@@ -188,7 +188,7 @@ def open_comparision_in_browser(self, owner, branch):
         base_owner = base_remote.owner
         base_branch = self.get_integrated_branch_name()
 
-        open_in_browser(urllib.urlencode("{}/compare/{}:{}...{}:{}?expand=1".format(
+        open_in_browser(urllib.parse.urlencode("{}/compare/{}:{}...{}:{}?expand=1".format(
             url,
             base_owner,
             base_branch,

diff --git a/github/github.py b/github/github.py
@@ -96,7 +96,7 @@ def open_file_in_browser(rel_path, remote, commit_hash, start_line=None, end_lin
         lines=line_numbers
     )
 
-    open_in_browser(urllib.urlencode(url))
+    open_in_browser(urllib.parse.urlencode(url))
 
 
 def open_repo(remote):
@@ -147,7 +147,7 @@ def github_api_url(api_url_template, repository, **kwargs):
     return fqdn, "{base_path}{path}?{query_params}".format(
         base_path=base_path,
         path=request_path,
-        query_params=interwebs.urlencode(kwargs))
+        query_params=interwebs.parse.urlencode(kwargs))
 
 
 def validate_response(response, method="GET"):

diff --git a/gitlab/commands/merge_request.py b/gitlab/commands/merge_request.py
@@ -174,7 +174,7 @@ def open_mr_in_browser(self):
 #         base_owner = base_remote.owner
 #         base_branch = self.get_integrated_branch_name()
 
-#         open_in_browser(urllib.urlencode("{}/compare/{}:{}...{}:{}?expand=1".format(
+#         open_in_browser(urllib.parse.urlencode("{}/compare/{}:{}...{}:{}?expand=1".format(
 #             url,
 #             base_owner,
 #             base_branch,

diff --git a/gitlab/gitlab.py b/gitlab/gitlab.py
@@ -98,7 +98,7 @@ def open_file_in_browser(rel_path, remote, commit_hash, start_line=None, end_lin
         lines=line_numbers
     )
 
-    open_in_browser(urllib.urlencode(url))
+    open_in_browser(urllib.parse.urlencode(url))
 
 
 def open_repo(remote):
@@ -151,7 +151,7 @@ def gitlab_api_url(api_url_template, repository, url_params={}, **kwargs):
     return fqdn, "{base_path}{path}?{query_params}".format(
         base_path=base_path,
         path=request_path,
-        query_params=interwebs.urlencode(kwargs))
+        query_params=interwebs.parse.urlencode(kwargs))
 
 
 def validate_response(response, method="GET"):