Merge pull request #910 from kaste/fix-909

Pass startupinfo to `subprocess.check_output`
timbrel · Apr 4, 2018 · fd6ee9c · fd6ee9c
2 parents 83f7721 + 81edb9e
commit fd6ee9c
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/core/git_command.py b/core/git_command.py
@@ -303,7 +303,13 @@ def git_binary_path(self):
                 git_path = shutil.which("git")
 
             try:
-                stdout = subprocess.check_output([git_path, "--version"]).decode("utf-8")
+                startupinfo = None
+                if os.name == "nt":
+                    startupinfo = subprocess.STARTUPINFO()
+                    startupinfo.dwFlags |= subprocess.STARTF_USESHOWWINDOW
+
+                stdout = subprocess.check_output(
+                    [git_path, "--version"], startupinfo=startupinfo).decode("utf-8")
             except Exception:
                 stdout = ""
                 git_path = None