Fix: check the nullness of project_savvy_settings #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asfaltboy
reviewed
Sep 21, 2018
core/settings.py
Outdated
| @@ -11,7 +11,7 @@ def get(self, key, default=None): | |||
| view = window.active_view() | |||
| project_savvy_settings = view.settings().get("GitSavvy", {}) | |||
|
|
|||
| if key in project_savvy_settings: | |||
| if project_savvy_settings and key in project_savvy_settings: | |||
There was a problem hiding this comment.
Can also be fixed by doing this on line 12:
project_savvy_settings = view.settings().get("GitSavvy") or {}
Not sure which style we prefer
There was a problem hiding this comment.
I like your suggustion asfaltboy
asfaltboy
approved these changes
Sep 21, 2018
randy3k
force-pushed
the
project_savvy_settings
branch
from
0bf07cb
to
9acce65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1007