Do not imperatively refresh ui after Log actions #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The three calls herein used `self.view` which is not defined since `GsLogActionCommand` is a `WindowCommand`. So basically all commands raised and did nothing. I think doing nothing is the correct approach here since after closing the panel, `on_activated` callbacks run for all important views anyway. To actually refresh _other_ visible views beside the active one would be a useful feature though.
|
Thanks. Good catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The three calls herein used
self.viewwhich is not defined sinceGsLogActionCommandis aWindowCommand. So basically all commands raisedand did nothing.
I think doing nothing is the correct approach here since after closing the
panel,
on_activatedcallbacks run for all important views anyway.To actually refresh other visible views beside the active one would be a
useful feature though.