Actually update the status bar for transient views #1101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1099
To what I know, your fix in #1100 is too complicated. Officially, transient views are exactly these views when you have an otherwise empty window.
So I think we check the window anyway, then the group for the widgets and otherwise just return.
Basically saying, it was a feature of my code that it was not calling
git status
for these temporary views. If we don't want that, I think we can just do this here.