Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not close panel views when cycling dashboards #1115

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

kaste
Copy link
Collaborator

@kaste kaste commented Feb 20, 2019

Fixes #1097

@randy3k
Copy link
Collaborator

randy3k commented Feb 20, 2019

I believe it was used to hide the additional information panel of git: graph.
We may need a more specific solution rather than not doing hide_panel

@randy3k
Copy link
Collaborator

randy3k commented Feb 25, 2019

#1116 replaces this

@randy3k randy3k closed this Feb 25, 2019
@kaste
Copy link
Collaborator Author

kaste commented Feb 25, 2019

🤔 no don't think so, currently <tab>ing closes any panel which is resolved here.

#1116 adds a fancy auto-close panel feature for the log graph only.

@randy3k randy3k reopened this Feb 25, 2019
@kaste kaste force-pushed the dont-close-panel-views-on-tab branch from da0d2f3 to 5648e50 Compare March 20, 2019 10:36
@kaste
Copy link
Collaborator Author

kaste commented Mar 20, 2019

Rebased. Since you pulled #1116 you should also pull this one.

@stoivo stoivo merged commit 13be1f1 into timbrel:dev Mar 29, 2019
@kaste kaste deleted the dont-close-panel-views-on-tab branch March 29, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants