Fix Issue 624

[jipumarino]

self.file_path and self.repo_path are None when view is cached.

Fixes #624

[stoivo]

It work like it should. Thanks for your contribution. Till next time, your commit message should me something more descriptive

Improve: Show open inline diff if it already open form statu dashboard

fix 624

I can change the commit message

I will leave it open 2 days for discussion, if wanted.

[jipumarino]

Thank you @stoivo, this was my first time using the "edit" feature from github, I didn't realize I was writing a commit message instead of the pull request title until it was done; I'll appreciate it if you change it.

I'm not sure yours is correct though, this feature was already implemented, I was just fixing an error introduced in 77471fd#diff-1d123c94cf2d78df2c8edace6fa6ee97R70

[stoivo]

I just glared at the code. I don't understand why my path 77461fd broke this.

[jipumarino]

Because of what I commented before. When the diff view is already open both self.repo_path and self.file_path are set to None at that point (not sure why that happens though).

When it's not open, those properties get set in this loop: 77471fd#diff-1d123c94cf2d78df2c8edace6fa6ee97L65

I tried replicating that loop in the other if branch, but it didn't work. This was the most straightforward solution.

[stoivo]

Thanks again