do not check if HEAD is rebased #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randy3k
force-pushed
the
randy3k/rebase_check
branch
from
240cb6c
to
ef89be4
Compare
|
I don't really use this part of gitsavvy, so I'm not sure how it should be. |
|
Most of the related code in this PR was written by @divmain, I guess he will be the best one to review this. |
randy3k
force-pushed
the
randy3k/rebase_check
branch
from
e395e04
to
1f0fe1b
Compare
randy3k
force-pushed
the
randy3k/rebase_check
branch
from
1f0fe1b
to
70ec1fc
Compare
|
Sorry for the long wait. These changes look mostly cosmetic, and fit in well with well-used parts of the codebase. Merging. |
divmain
approved these changes
May 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not necessary to check if HEAD is rebased. Manuplicating commits should be always possible (if there are no merges).
close #619