Fix: Log all output even binaries #663
Conversation
|
A review? |
|
I am not sure what was the issue and why it fixes the issue....perhaps @divmain may know more. |
|
In this PR #606 we do some command without decoding the output because we are sending it back in some other command. I made it pass the binary around therefor I would need to deal with the encoding and it would always keep the correct encoding. And I make a bug. When you would log this command which only worked with binaries it would save the messages. Here https://github.com/stoivo/GitSavvy/blob/409e5eefbf39f53c31d3d6253a6ea5246e7bc583/common/util/debug.py#L36 when we dump it to json if fails since json.dump don't work with binaries. |
common/util/debug.py
Outdated
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| _log = [] | |||
| enabled = False | |||
| encoding_not_utf8 = "{} was sent as binaries and we dont know the encoding, not utf-8" | |||
There was a problem hiding this comment.
I guess it is a convention to use upper cases for such constant!?
There was a problem hiding this comment.
Does python make it immutable if it is uppercase?
There was a problem hiding this comment.
Strings are always immutable, and names can always be overridden, no matter the casing. It's only a convention for readability sake (AFAIK).
There was a problem hiding this comment.
That's different than ruby, which I have more experience with.
Some command in inline diff are workning with binaries so when we try to log. Try to decode it as utf-8, otherwise fail. closes timbrel#662
|
Merge? |
Some command in inline diff are workning with binaries so
when we try to log. Try to decode it as utf-8, otherwise
fail.
closes #662