[WIP] refactoring blame walker #717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maintainerd logging is enabled for this repository. All actions related to rules and their enforcement will be logged here as a permanent record. Click to view log...
|
randy3k
force-pushed
the
randy3k/blame
branch
4 times, most recently
from
9d58ea2
to
25617ff
Compare
|
I tried it on a large repo of 30k commits and a relatively large file (3k lines). These are significant delay (~3s-7s) from the quick panel to the highlighting. I did some profiling, 50% of time was spent in |
randy3k
force-pushed
the
randy3k/blame
branch
13 times, most recently
from
ec05579
to
ab028df
Compare
7 tasks
randy3k
changed the title
randy3k
changed the title
randy3k
force-pushed
the
randy3k/blame
branch
2 times, most recently
from
7fbfd65
to
c1b0970
Compare
Internal: maintainerd - don't enforce empty line
Internal: add ISSUE_TEMPLATE.md and PULL_REQUEST_TEMPLATE.md
This change also refactors response validation for reuse
Feature: GitHub create fork command
Enhancement: select the branch name while creating a new branch
use `last_page_empty_message` instead of `empty_message` if the last page is empty also refactor `show_paginated_panel` in a way discussed earlier
Feature: git stash in command panel
Before, we used a base ref that was specified in settings, otherwise defaulting to hardcoded "master". Now, we find the nearest common ancestor branch (after some filtering) and use that as our default base, still allowing users to override it in settings.
- use .get_active_remote_branch().name_with_remote for clarity - be consistant with string formatting in log calls - limit to max revision count in `git rev-list` call - rename max_iterations to max_revisions for clarity
This avoids wrongly using commit message parts that include strings in square brackets as branches. For example before this fix, the following commit would return WIP as branch name: `[develo] [WIP] Fix: some bug`
- As suggested by @divmain the method was moved into a separate mixin for reuse, as well as, splitted into smaller parts - Use `git branch --merged` instead of `--no-merged. This fixes a bug where the most obvious branches are not returned since no-merged means that only branches that are "unreachable" from given node are returned, and we actually want the opposite.
Feature: better selection of base ref branch
randy3k
force-pushed
the
randy3k/blame
branch
from
ab694f0
to
4b9afe5
Compare
|
It is hard to merge this. I am going to split this PR. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #709 , if that is merge, this will be rebased.# 709 has merged.It is a refactoring of the GsBlameCommand, specifically it brings these new features.
syntax highlight
line forwarding (the cursor will follow via history instead of going to a random place)
use [m] to switch between
detect within file,detect within commitanddetect within all commitsinstead of showing a panel to ask every time. The origin popup is also modified to show less text.the options of the BlameActionCommand are renamed. Actually, still not sure the best to name them.
The maintainers of this repo require that all pull request submitters agree and adhere to the following:
(required)
The maintainers of this repository require you to select the semantic version type that
the changes in this pull request represent. Please select one of the following: