Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use the decoded output #898

Merged
merged 2 commits into from
Mar 19, 2018
Merged

Fix: use the decoded output #898

merged 2 commits into from
Mar 19, 2018

Conversation

randy3k
Copy link
Collaborator

@randy3k randy3k commented Mar 19, 2018

close #897

Copy link
Member

@stoivo stoivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still get

STDIN
b'diff --git a/core/interfaces/branch.py b/core/interfaces/branch.py\n--- a/core/interfaces/branch.py\n+++ b/core/interfaces/branch.py\n@@ -15,0 +15,1 @@\n+\n'
> /usr/local/bin/git apply --unidiff-zero --cached -

	"show_panel_for":
	[
		"commit",
		"apply",
		"pull",
		"push"
	],
	"live_panel_output": true,

@randy3k
Copy link
Collaborator Author

randy3k commented Mar 19, 2018

That's the stdin, not sure why it needs to be encoded https://github.com/divmain/GitSavvy/blob/e9312e9b5b1203481aa69667fb48400ceacd6cba/core/git_command.py#L199-199

Update:I was a mistake of mine. Should be fixed now.

@randy3k
Copy link
Collaborator Author

randy3k commented Mar 19, 2018

Added a time elapsed message after the git command is done. I found that it is quite useful when the git command is fired asynchronously.

Copy link
Member

@stoivo stoivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfaltboy asfaltboy merged commit 797f79b into release/2.17.0 Mar 19, 2018
@stoivo stoivo deleted the log_panel branch March 20, 2018 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants