Help text #988
Merged
Help text #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoivo
approved these changes
Aug 17, 2018
|
Then we wait with releaseing 2.17.4 |
|
Should this commit be cherrypicked into dev? |
|
Sure. Let me do it. |
|
done a25ddbb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@oerp-odoo discovered a bug on committing/amending when the last line of the commit message is not empty (when
commit_on_closeistrue). It is merely due to the fact thathelp_textcan a leading "\n". I have also added some conditions for helping to detect the message text.@stoivo I think we should also merge this to release 2.17.4. Please review it and we might want to delay the release of 2.17.4 for a few days for testing.