Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local flake registry freezes NUR input #347

Closed
bbjubjub2494 opened this issue Jul 19, 2021 · 4 comments
Closed

local flake registry freezes NUR input #347

bbjubjub2494 opened this issue Jul 19, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@bbjubjub2494
Copy link
Contributor

Expected Behavior

Running flk update on a DevOS machine should update the nur input to the tip of the appropriate git branch.

Current Behavior

flk update idempotently converts the input to the equivalent path:/nix/store/xxx-source.

Possible Solution

Explicitly specify nur.url = "github:nix-community/nur", downside being that it is redundant- and silly-looking as well as fragile.

Altternatively, fix this in a more general way, since this is the second time such an issue occurs (#142) which suggests there's an underlying issue.

Steps to Reproduce

  1. Be on a DevOS based system
  2. Try to update any flakes that requires nur from the registry
  3. Check commit message and contents of flake.lock

Context

I use NUR together with DevOS. I believe based on looking at the code that this issue is still present in develop.

Your Environment

I use a system configuration based on the current tip of core. This phenomenon hit me on Friday at this commit but took me until today to realize.

@bbjubjub2494 bbjubjub2494 added the bug Something isn't working label Jul 19, 2021
@Pacman99
Copy link
Member

This is a side effect of 3d3d6bb. Which makes it so that a local flake registry is created from all your inputs. So once you rebuild once and the flake registry gets created the next time you update your inputs they get set to paths in the nix store.

The goal with that commit and the feature in fup is to allow you to easily do nix shell nur#... and not have to download the flake. But it creates side effects like this when you use the nix registry. I'm ok with reverting that commit so thats its opt-in. I generally avoid the public nix registry so I like having a local one auto generated, but I understand that its frustrating for others who make use of the registry.

@bbjubjub2494
Copy link
Contributor Author

Absolutely, the custom registry comes handy sometimes. OTOH, when they shadow the normal one it breaks assumptions. Nix has a --no-registries flag, but not one that could be used to select the normal registry. Maybe it should have an option for that?

@blaggacao
Copy link
Contributor

blaggacao commented Jul 20, 2021

I agree, we should make this opt-in.

Nix has a --no-registries flag, but not one that could be used to select the normal registry. Maybe it should have an option for that?

There has been some upstream work recently, let me check if I find it.

Here, it is: NixOS/nix#4976

@Pacman99
Copy link
Member

We no longer set the registry by default to all your inputs. Since that feature is now opt-in, I think we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants