Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run docker build less often #713

Open
jbr opened this issue Jan 3, 2024 · 0 comments
Open

Run docker build less often #713

jbr opened this issue Jan 3, 2024 · 0 comments

Comments

@jbr
Copy link
Contributor

jbr commented Jan 3, 2024

Currently, the slowest GitHub actions are the docker builds. The only ways the docker builds would fail are:

  • a new top level file or directory that is COPY-ed is added or removed
  • npm ci or npm run build fail
  • cargo build fails
  • the Dockerfile includes changes that need iteration

npm ci/run build and cargo build are covered directly by other GitHub actions

In order to mitigate against merging breaking changes to main, we could run the docker builds IFF the list of top level files has changed, or if the Dockerfile has changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant