Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon color selector #19

Merged
merged 3 commits into from Jan 28, 2019
Merged

Icon color selector #19

merged 3 commits into from Jan 28, 2019

Conversation

yccheok
Copy link

@yccheok yccheok commented Dec 18, 2018

Hi @divyanshub024,

May I propose the following changes?

  1. A color indicator, to indicate whether current drawing eraser mode is on or off.
  2. A color indicator, to indicate whether an icon is currently being pressed.

The effect looks like following

Eraser is off

earse-off

Eraser is on

earse-on

When icon is pressed

x

Thank you very much!

Regards,
Cheok

@divyanshub024 divyanshub024 merged commit 8f12977 into divyanshub024:master Jan 28, 2019
@divyanshub024
Copy link
Owner

@yccheok Thanks a lot for this amazing work!! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yccheok @divyanshub024