Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error should implement Sync #71

Closed
dfaust opened this issue Jan 21, 2017 · 3 comments
Closed

Error should implement Sync #71

dfaust opened this issue Jan 21, 2017 · 3 comments

Comments

@dfaust
Copy link

dfaust commented Jan 21, 2017

Error currently uses c pointers, which don't implement the Sync trait.
error-chain requires errors to implement the Sync trait since version 0.8.0.

See also: rust-lang-deprecated/error-chain#110
@diwic
Copy link
Owner

diwic commented Jan 22, 2017

Error is an FFI object. I can't guarantee that Error is sync. And even if we scrutinized the C implementation and found it to be Sync, I can't guarantee that it will remain sync in future releases of libdbus.

Sorry.

@diwic
Copy link
Owner

diwic commented Jan 22, 2017

What I could do is implement From back and forth between Error and MethodErr, the latter being a pure Rust struct with nothing in it that should make it non-Sync. Would that help?

@dfaust
Copy link
Author

dfaust commented Jan 22, 2017

I'm not sure what MethodErr is, but something like that would be great. Because right now dbus-rs is incompatible with error-chain and it seems that I'm not the only one who thinks that error-chain is a very valuable crate.

@diwic diwic closed this as completed in 34f1be1 Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dfaust @diwic