remove duplicate data store #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. Thanks! As for "會導致該目標無法被釋放", let's keep it this way for now. |
diwu
added a commit
that referenced
this pull request
Jun 22, 2015
…recursionHelper2 remove duplicate data store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @diwu,
在 trace 紅框出現的邏輯時, 發現在
dwu_recursionHelper2這個 function 裡面, 有部分可以小幅修改一下,第一個是, 我們應該可以只用一個 container 就好. 所以我把
cgImageRefSet整個拆掉了.第二個是, 純取 address 的話, 可以用
%p取代%@.另外一個部分, 當
layer.delegate被放到cgImageRefDict時, 會導致該目標無法被釋放, 但是要改起來的話, 會動到比較多地方, 我暫時就先不動他.