Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show notice to users before auth #20

Closed
avi-perl opened this issue Sep 22, 2022 · 2 comments · Fixed by #23
Closed

Do not show notice to users before auth #20

avi-perl opened this issue Sep 22, 2022 · 2 comments · Fixed by #23

Comments

@avi-perl
Copy link

avi-perl commented Sep 22, 2022

  • django-admin-env-notice version: N/A
  • Django version: N/A
  • Python version: N/A
  • Operating System: N/A

Description

I'm wondering if you would be open to adding a new feature or accepting a PR along the following lines:

On my sites, I like to put additional information in the env bar, such as the name of the git branch the site is on, the sha, and other information that ideally, I'd want to keep out of the public eye. It would be possible to modify the template to only show the bar if the user is_authorized, effectively limiting the data in the header to logged-in users. This feature would default to showing the bar, but could be enabled via an environment variable.

What do you think?

@dizballanze
Copy link
Owner

Hi! Sounds good to me. Feel free to open PR!

@dizballanze
Copy link
Owner

Fixed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants