Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for multiple version of the docs? #7

Closed
abe-101 opened this issue Apr 28, 2024 · 3 comments
Closed

support for multiple version of the docs? #7

abe-101 opened this issue Apr 28, 2024 · 3 comments

Comments

@abe-101
Copy link
Sponsor Member

abe-101 commented Apr 28, 2024

Does anyone know if the newly designed site ever supported multiple version of the docs

Currently on the site I don't see any way t choose a version.
as well as after reviewing the deploy process it seems it does a dry cp of the docs dir leaving out all the git versions - so I cannot imagine how the site hosted on GitHub pages from this projects gh-pages branch would even now about different versions

If you have any insight please share

@abe-101
Copy link
Sponsor Member Author

abe-101 commented Apr 28, 2024

on the other hand the original docs in the dj-stripe repos very clearly does support multiple version as is evident from the gh-pages branch which has a dedicated folder for each version

Compare that to the gh-pages branch in this repo which clearly only has on version deployed

@abe-101
Copy link
Sponsor Member Author

abe-101 commented Apr 28, 2024

I suspect the the current ci workflow action was blindly copied from dj-stripe to this repos

the action running on this repos no awareness of the commit tag in the main dj-stripe repo
So (unless I'm mistaken) this line makes no sense:

- name: Deploy (and Update) docs for the branch, ${GITHUB_REF##*/}
run: poetry run mike deploy --push --rebase "${GITHUB_REF##*/}"

What its supposed to do is detect teh tag (2.5, 2. etc) and push the docs to the current folder

@abe-101 abe-101 closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant