Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans on live + test mode with the same stripe IDs #464

Closed
jleclanche opened this issue Mar 16, 2017 · 5 comments
Closed

Plans on live + test mode with the same stripe IDs #464

jleclanche opened this issue Mar 16, 2017 · 5 comments
Milestone

Comments

@jleclanche
Copy link
Member

Plan.stripe_id is inherited from StripeObject which makes it unique. Plan stripe IDs don't work quite the same way as other stripe objects though because their IDs are user-input and users are likely to use the same ID on live and test. If this is not supported, it needs to be documented, but I personally think we should move to a unique_together w/ stripe_id + livemode for Plan.

@kavdev
Copy link
Member

kavdev commented Mar 20, 2017

Makes sense and sounds good

@jleclanche
Copy link
Member Author

PS: I think the same situation is true for coupons, once we get support for those.

@wedwardbeck
Copy link

Not sure if this is exactly related to my question, but seems to be close. I currently only have a text pub & secret key. I just updated to 1.0.0 and am getting odd warnings.

putting only tst keys, it tells me:
CRITICALS:
?: (djstripe.C001) Could not find a Stripe API key.
HINT: Add STRIPE_TEST_SECRET_KEY and STRIPE_LIVE_SECRET_KEY to your settings.

Should't I be able to test with only test keys populated (that's all I have right now) if the LIVE setting is FALSE?

@jleclanche
Copy link
Member Author

Make sure you specify STRIPE_LIVE_MODE = False and STRIPE_TEST_SECRET_KEY = "sk_text_XXXXX"

@jleclanche jleclanche added this to the 2.0.0 milestone Jul 31, 2018
@jleclanche
Copy link
Member Author

I'm gonna go ahead and close this as a wontfix. Given that plans are able to have unique IDs now it seems like stripe is "deprecating" having these non-unique IDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants