Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse CSS variables provided by django #129

Open
VaZark opened this issue Apr 18, 2024 · 1 comment
Open

Reuse CSS variables provided by django #129

VaZark opened this issue Apr 18, 2024 · 1 comment

Comments

@VaZark
Copy link

VaZark commented Apr 18, 2024

My browser defaults to prefer dark but when I toggle to light mode on Django 5.0, I notice that certain elements remain on dark mode colors.

Taking a look at the CSS, I realise that the colours are hard-coded. Django has migrated to using CSS variables for the admin page sometime during the 3.0 release cycle. Reusing the same variables in the libraries CSS would make the entire experience more consistent with upstream OOTB. It also reduces overhead as those who wish to merely customise the colours can modify the default variables and forget the rest.

image

@VaZark
Copy link
Author

VaZark commented Apr 18, 2024

I can take a look and send in a PR sometime over the month if you're open to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant