Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans about ckeditor 5 #482

Closed
jiuri0624 opened this issue Apr 18, 2018 · 15 comments
Closed

Plans about ckeditor 5 #482

jiuri0624 opened this issue Apr 18, 2018 · 15 comments

Comments

@jiuri0624
Copy link

jiuri0624 commented Apr 18, 2018

有没有计划支持到ckeditor5, 5的操作编辑体验非常棒。

@matthiask
Copy link
Member

The feature set of django-ckeditor mostly depends on individual contributions, so if you or someone else wants to contribute a ckeditor5 update, this would most probably be very welcome.

@riklaunim
Copy link
Contributor

django-ckeditor has two parts - file upload/management via third party ckeditor plugin and a form field that initializes the editor itself. Moving to ckeditor5 we likely will loose current file management in favor of their build it simpler uploader. Form field integration can still be done. In the end it will be a major version bump, not fully backward compatible.

@Natim
Copy link

Natim commented May 14, 2018

I was going to ask about the same question, should we start a fresh project instead?

Note that Ckeditor5 is completely different from ckeditor4

@riklaunim
Copy link
Contributor

Didn't had the opportunity to check CkEditor 5 yet. This package started as a "ckeditor for django with file upload". Having that file upload is a rather big thing.

Also packaging a JS package into a Python package isn't the best thing and that should change as well.

@0x85dotdev
Copy link

@Natim a fresh repo sounds like the best way to do a ckeditor5 wrapper. It's a very big version jump, and natively solves a lot (especially with image handling) that the Django app won't have to accomodate.

I'm interested enough to contribute PR's, but I don't see being able to expedite on my own.

@guettli
Copy link

guettli commented Jan 7, 2019

I think the title of this issue should get updated. And then the duplicate #508 can be closed. AFAIK I can't do both.

@matthiask matthiask changed the title ckeditor Plans about ckeditor 5 Jan 7, 2019
This was referenced May 7, 2020
@hashlash
Copy link
Contributor

You might want to check this https://github.com/hvlads/django-ckeditor-5

@pulse-mind
Copy link

Hi,

First, thank you to all the contributors who work on this project.

CKEditor 4 is supposed to be End Of Life in June 2023 (https://support.ckeditor.com/hc/en-us/articles/115005281629-How-long-will-CKEditor-4-be-supported-). So it become a critical problem for many users : security, stability, bugs...

Do you plan to to something ? may be merge with https://github.com/hvlads/django-ckeditor-5 where @hvlads did a very good job... ?

Best regards,
Fred

@matthiask
Copy link
Member

Hi,

It is my understanding that the licensing of CKEditor 5 makes this question not easy to answer. CKEditor 5 is only free if the open source project's license is compatible to the GPL. https://ckeditor.com/docs/ckeditor5/latest/support/licensing/license-and-legal.html

While I totally understand that stance and while I'm not exactly a fan of free labor either upgrading to CKEditor 5 raises many questions and would probably mean that users of django-ckeditor in turn have to ask themselves the hard questions.

@pulse-mind
Copy link

Yep, it is a good question.
Some information about the licence :

CKEditor 5 is distributed under a GPL 2+ copyleft license. If you are not compatible with GPL 2+ license restrictions and wish to use our solutions

Which allow to do a lot of things.

@pulse-mind
Copy link

And a product which is not maintained is a problem, the first and the main reason is for security purpose, I would not start with and If I am already a user I would think to migrate to something else (same product with the current version of another product).

@goapunk
Copy link

goapunk commented Jun 14, 2023

@matthiask sorry for the dupe, I'll repost my question here: ckeditor4 is end of life since june 2023. Are there any plans to move to ckeditor5 ? Or would you be accepting PRs for that?

@matthiask
Copy link
Member

I think so, yes. But I still have doubts regarding the licensing situation. Of course the GPL isn't the AGPL, but. If we bundle CKEditor 5, my understanding is that we'd have to change django-ckeditor's license, which in turn means that everybody distributing packages depending on django-ckeditor would have to think about their licensing as well. I'm not a lawyer, that isn't legal advice, but I would really want some clarifications here.

@goapunk
Copy link

goapunk commented Jun 14, 2023

I see the problem, I guess it also has been discussed extensively over at the ckeditor repository. Note that they are willing to grant exceptions to open source projects (see here). django-ckeditor could ask them to get a MIT or BSD 3-Clause if licensing is the biggest concern here.

@matthiask
Copy link
Member

This has gotten more important by the deprecation of CKEditor 4 (see for example #761) but it still won't happen. Since CKEditor 5 only has a GPL-licensed open source version django-ckeditor would also have to be licensed under the GPL, and in turn also all projects which use / link django-ckeditor, if they are distributed. At least that's my understanding of how this works. While I understand and appreciate the GPL I don't want to attempt relicensing django-ckeditor under a license which makes some of my own open source work harder and less useful.

I'm going to close this issue as not planned, and will point people towards https://github.com/hvlads/django-ckeditor-5 (the authors seem to have a different interpretation of the licensing issues)

@matthiask matthiask closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2024
@matthiask matthiask pinned this issue Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants