Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates refer to older style Django admin icons. #639

Closed
joshuajonah opened this issue Dec 15, 2015 · 4 comments
Closed

Templates refer to older style Django admin icons. #639

joshuajonah opened this issue Dec 15, 2015 · 4 comments
Milestone

Comments

@joshuajonah
Copy link

All of the Django admin icons are now SVGs nd the links need to be updated to them somehow hopefully without breaking pre-1.9 versions.

For example:
https://github.com/divio/django-filer/blob/develop/filer/templates/admin/filer/widgets/admin_file.html#L24
refers to admin/img/icon_deletelink.gif. This file no longer exists in 1.9 and was replaced with admin/img/icon-deletelink.svg.

@stefanfoulis
Copy link
Contributor

fixed in #670

@stefanfoulis stefanfoulis added this to the 1.2.0 milestone Feb 25, 2016
@stefanw
Copy link
Contributor

stefanw commented Mar 26, 2018

@stefanfoulis It looks like the admin/img/icon_deletelink.gif has made its way back into the widget's template.

https://github.com/divio/django-filer/blob/develop/filer/templates/admin/filer/widgets/admin_folder.html#L18

@stefanfoulis
Copy link
Contributor

🤦‍♂️

@stefanw
Copy link
Contributor

stefanw commented Mar 26, 2018

This can lead to parts of the admin not rendering at all: if ManifestStaticFilesStorage is used, the referenced static file can't be found, an error is raised and suppressed by template rendering. In my case this did not render the Filer Folder Permissions Add page correctly, which made adding permissions impossible.

See this similar issue in Django CMS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants