New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sass, different results using compressor and without, causing parsing errors #827
Comments
looks pretty bad. any help fixing this would be appreciated, i'll likely not have the time for the coming weeks. |
I'll have a go. I'm not familiar with your codebase so any pointers on where to start / any hunches would be very valuable. |
A couple of thoughts:
|
I have tried including either sass version or a pre-built bootstrap.css file in a compressor block followed by a file just containing a body background:green as a checklight for valid/parseable CSS. I'm getting 'green' for the pre-built .css version, but not for .sass—where compressor builds bootstrap. |
@wjdp OK Thanks. Hmmm. In that case can I suggest putting a breakpoint in Then in |
i'm looking into this right now. the problem is the same as #764. the CssAbsoluteFilter uses
i don't want to spend much time on this and am looking into option 1, if anyone wants to create a more robust solution, i'd be glad to review that. |
proposed fix in #828. it does not actually handle nested parenthesis at all, it just expects closing quotes if there are opening ones (so |
Shall do |
@carltongibson Can confirm that PR has fixed this issue for me. Thank you @karyon for your very quick work! 😄 |
Awesome 👏🏽 thanks for the follow up. |
Hello, I'm running into an issue while using Bootstrap 4 alpha 6. Encountered that all CSS after the include of BS4 was ignored by the browser. Dug deeper and found parsing error of the generated css.
I'm using Django 1.8.17, Compressor 2.1.1, Sass 3.4.22
I shall document here the first parse error I found.
The error is the double quote
"
instroke='rgba(0, 0, 0, 0.5")',
whereas it should bestroke='rgba(0, 0, 0, 0.5)'
. This causes parsing errors in the document.Invalid Line (via dj compressor)
Valid line (via sass direct)
Matches with pre-compiled version.
Souce of background-image
How we generate via dj compressor
The text was updated successfully, but these errors were encountered: