Fixed input group size in Bootstrap 4 #1114
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1114 +/- ##
=======================================
Coverage 97.24% 97.25%
=======================================
Files 23 23
Lines 2836 2844 +8
Branches 243 243
=======================================
+ Hits 2758 2766 +8
Misses 38 38
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
smithdc1
force-pushed
the
1080-ds
branch
3 times, most recently
from
2dd8847
to
6972948
Compare
smithdc1
changed the title
|
OK -- I've trimmed this down to just the append and related classes. We can come back to "with buttons" as a separate change. |
|
I'll review it, latest on the next weekend and probably and earlier :-) |
|
No rush! 🙂 |
| PrependedText('field_name', StrictButton("Go!"), css_class="input-sm") | ||
| PrependedText('field_name', StrictButton("Go!"), css_class="input-lg") | ||
|
|
||
| # Bootstrap 4 - Wrapping div needs size class. Use `input_size`. |
There was a problem hiding this comment.
If we don't pass input_size what happens? I thought that it all still works with the default Bootstrap size, right?
Perhaps this could be added here stating that input_size is optional, but that if it's passed then it's used in certain way?
There was a problem hiding this comment.
@cpina -- you are right but I'm struggling to find the right way to say this succinctly. Can you have a look at my next itteration here?
@cpina this is still WIP, but thought it worth sharing more publicly my progress with this. Notes:
input_sizeis spot on. I think we need this for the append inputs as wellField_with_buttonsI've not really looked at. Tempted to chop it from this PR and get the rest of it merged.