Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Allow only certain characters in the "table name" form in the query interface #78

Closed
galkinAIP opened this issue Sep 8, 2021 · 4 comments · Fixed by #179
Closed
Labels
Milestone

Comments

@galkinAIP
Copy link
Member

The "table name" currently allows spaces, etc. in the Query form. The form should allow only alphanumerical characters and "_", "-".

@triole
Copy link
Contributor

triole commented Sep 9, 2021

The filter was added. Here is the commit: 325fde6

@jochenklar
Copy link
Member

Hi @galkinAIP , @triole , any reason why this was not merged before? I would add a setting for this though. Another possibility was to chain a django.core.validators.RegexValidator with r'^[\w]+\Z' with the current TableNameValidator (and get rid of the - as well).

Anyway, is it just to make cli access for admins better? Daiquiri seems to work fine with weird tablenames.

@agy-why agy-why added the feature feature request label Jan 3, 2023
@agy-why agy-why changed the title Allow only certain characters in the "table name" form in the query interface FEATURE: Allow only certain characters in the "table name" form in the query interface Jan 3, 2023
@agy-why agy-why added this to the verion 0.4.2 milestone Feb 6, 2023
@glaubervila
Copy link

Hi @galkinAIP , @triole , any reason why this was not merged before? I would add a setting for this though. Another possibility was to chain a django.core.validators.RegexValidator with r'^[\w]+\Z' with the current TableNameValidator (and get rid of the - as well).

Anyway, is it just to make cli access for admins better? Daiquiri seems to work fine with weird tablenames.

Hi, I am testing daiquiri and in my environment, when there is space in the table name the download fails.

@kimakan
Copy link
Contributor

kimakan commented Jun 21, 2023

Can confirm. Currently, whitespaces in the table name break the download.

@kimakan kimakan linked a pull request Jul 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants