Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIxes to run dbbackup management command in Postgres for non-latin Windows. #273

Merged
merged 1 commit into from Aug 26, 2018

Conversation

Dmitri-Sintsov
Copy link
Contributor

Fix 'pg_dump too many command-line arguments' error in Windows / Postgres 9.4 (command-line arguments must precede database name).

Fix non-Latin bytes error result of pg_dump being displayed / logged as hex bytes instead of easily readable utf-8 string.

…gres 9.4 (command-line arguments must preceed database name). Fix non-Latin bytes error result of pg_dump being displayed / logged as hex bytes instead of easily readable utf-8 string.
@ZuluPro
Copy link
Contributor

ZuluPro commented Dec 16, 2017

Thank for your contribution,
Could you tell me what was the error before this patch ?

@Dmitri-Sintsov
Copy link
Contributor Author

It was pg_dump 'too many command-line arguments' error in Windows / Postgres 9.4

@Merichbier
Copy link

It fixed the same problem (pg_dump 'too many command-line arguments' ), I'm using Windows 10, PostgreSQL 10.3 and Django 2.0.4

@WarToaster
Copy link

Also fixed my issue.
Win 10, Postgres 9.6.2, Django 1.11.1

WarToaster pushed a commit to WarToaster/django-dbbackup that referenced this pull request May 24, 2018
@ghost
Copy link

ghost commented Aug 11, 2018

Hi can you explain please why you rejected this pull request?

@ZuluPro
Copy link
Contributor

ZuluPro commented Aug 12, 2018

@momar07005 The PR hasn't been rejected.

It's just the project doesn't have active mainteners
And to accept this we must ensure it works with functional/unit tests and doesn't break non-windows users.

@Dmitri-Sintsov
Copy link
Contributor Author

Patched version works here locally in Ubuntu 18.04:

(ispdevenv) user@ispdev:~/work/ispdevenv/ispdev$ ./manage.py dbbackup -z
Backing Up Database: ispdevdb
Writing file to default-ispdev-2018-08-13-132053.psql.gz
(ispdevenv) user@ispdev:~/work/ispdevenv/ispdev$ ./manage.py mediabackup -z
Writing file to ispdev-2018-08-13-132111.tar.gz
(ispdevenv) user@ispdev:~/work/ispdevenv/ispdev$ 

Why does it break tests, I do not know.

@ZuluPro ZuluPro merged commit e51a1b5 into jazzband:master Aug 26, 2018
@ZuluPro
Copy link
Contributor

ZuluPro commented Aug 26, 2018

Merged with trust of community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants