Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FixtureConnector #309

Closed
wants to merge 1 commit into from
Closed

Add FixtureConnector #309

wants to merge 1 commit into from

Conversation

iosifnicolae2
Copy link

Part of #194

@iosifnicolae2 iosifnicolae2 mentioned this pull request Jun 29, 2019
Open
@ZuluPro
Copy link
Contributor

ZuluPro commented Jun 29, 2019

Hello @iosifnicolae2

Thank you very much for this PR, I have several recommandations:

  • Can you create a separate module for this Connector (not postgresql) ?
  • Can you use the Django command directly in Python ? I don't want a subproccess to be launched
  • Can you add unit tests ?

@iosifnicolae2
Copy link
Author

I'm really sorry, but I don't have enough time to do it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iosifnicolae2 @ZuluPro