Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fileno error fix #323

Closed
wants to merge 4 commits into from
Closed

Fileno error fix #323

wants to merge 4 commits into from

Conversation

useHTML5
Copy link

@ZuluPro
Copy link
Contributor

ZuluPro commented Apr 4, 2020

Hello @useHTML5
Could you write some tests ensuring this PR ?

@@ -1,3 +1,5 @@
pytz
six
Django>=1.5
paramiko #django-dbbackup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why paramiko ?

@@ -1,3 +1,5 @@
pytz
six
Django>=1.5
paramiko #django-dbbackup
django-storages #django-dbbackup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

django-storage should be an optional dependency

@ZuluPro
Copy link
Contributor

ZuluPro commented Apr 14, 2020

Hello @useHTML5
Could you also merge your commits into 1 ?

@jonathan-s
Copy link
Contributor

Since it's unclear what this is trying to fix I'm closing this.

@jonathan-s jonathan-s closed this Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants