Support disabling panels with the names in the docs. #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs hide the fact that the SQLPanel and TemplatesPanel live in a panel module. The DISABLE_PANELS config option previously required that panel module to be included in the path in order for the panel to be disabled. This change will check the panel's path against that config set and then check it again with the .panel. replaced as just . against the config set. Doing this replace blindly will support moving any other panel from it's own module into a package like the SQLPanel and TemplatesPanel. Fixes jazzband#687.
|
Yes, that makes sense, please merge. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs hide the fact that the SQLPanel and TemplatesPanel live in
a panel module. The DISABLE_PANELS config option previously required
that panel module to be included in the path in order for the panel
to be disabled.
This change will check the panel's path against that config set and
then check it again with the .panel. replaced as just . against the
config set.
Doing this replace blindly will support moving any other panel from
it's own module into a package like the SQLPanel and TemplatesPanel.
Fixes #687.