Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package name column added to Versions panel. #715

Closed
wants to merge 1 commit into from
Closed

Package name column added to Versions panel. #715

wants to merge 1 commit into from

Conversation

idlesign
Copy link
Contributor

Hi,

Since in Django 1.7+ ugettext is applied to app.verbose_name it might be hard to identify the very package name. Here it's solved by a new Package column: so we know both the package name and a title it is represented in Admin contrib.

@tim-schilling
Copy link
Contributor

Do you have an example of a package that would benefit from this change?

@idlesign
Copy link
Contributor Author

Those two are from my list, yet virtually it could be any app. The same way we localize verbose names in fields and model meta we can give our apps user-friendly names.

https://github.com/idlesign/django-sitetree/blob/master/sitetree/config.py#L9
https://github.com/idlesign/django-sitegate/blob/master/sitegate/config.py#L9

@aaugustin
Copy link
Contributor

I'm sorry, I failed to merge this PR for more than a year and it no longer applies.

But the underlying ideas sounds interesting and the implementation looks OK.

If you rebase it on master and ping me, I'll merge it.

@idlesign
Copy link
Contributor Author

Ended up with #859

@aaugustin aaugustin closed this Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants